New SerializedPageReader when dictionary page is provided #7087
+45
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungda
commented
Feb 6, 2025
Comment on lines
+530
to
+531
| /// Note: The first page in `page_locations` (if available) | ||
| /// must be the first data page to infer the dictionary page's location. |
There was a problem hiding this comment.
Is there a way to enforce or return error early when a user doesn't follow this? I believe, currently, the reader will panic if the first page location is not the first data page.
|
Not had time to look in detail, buf I wonder if rather than continuing to add ever more constructors, if it would be better to extract a builder? |
I can give it a try :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Our use case is that we have already iterate through all the page headers of the parquet file at the beginning so we know the location of the dictionary page so we don't want to have to pass the first data page in the
page_locationargument anymore.What changes are included in this PR?
Adds a new constructor to
SerializedPageReaderto make sure we don't break existing callers ofSerializedPageReader.Are there any user-facing changes?
Yes in a way that there is a new constructor but existing callers should still be able to function.