Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-proxy): abstract a base for ai-proxy #11991

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

In the previous ai-proxy-multi feat PR: #11986, the ai-proxy-multi module would overwrite the ai-proxy module functions.

image

Due to this, the ai-proxy plugin would execute ai-proxy-multi plugin's logic. This issue was found during some manual tests. The CI could not detect because it could not run properly as test::nginx could not initialise an nginx process as it could not find a certificate specified in the following test:

=== TEST 6: send request
--- custom_trusted_cert: /etc/ssl/cert.pem
--- request
POST /anything
{ "messages": [ { "role": "system", "content": "You are a mathematician" }, { "role": "user", "content": "What is 1+1?"} ] }
--- error_code: 401

The CI failure log: https://github.com/apache/apisix/actions/runs/13489934366/job/37686455127#step:19:190

image

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Feb 24, 2025
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed

@Revolyssup Revolyssup merged commit 35a59eb into apache:master Feb 25, 2025
30 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the abstract-a-base branch February 25, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants