Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(limit-count): make rate-limit response headers configurable #11831

Merged
merged 4 commits into from
Dec 18, 2024
Merged

feat(limit-count): make rate-limit response headers configurable #11831

merged 4 commits into from
Dec 18, 2024

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

Allow users to configure the names of rate-limit response headers using plugin-metadata.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request plugin labels Dec 16, 2024
nic-6443
nic-6443 previously approved these changes Dec 16, 2024
View reviewed changes
@kayx23 kayx23 self-requested a review December 18, 2024 08:43
kayx23
kayx23 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc LGTM

@shreemaan-abhishek shreemaan-abhishek merged commit 945e077 into apache:master Dec 18, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-6443 nic-6443 nic-6443 approved these changes

@kayx23 kayx23 kayx23 approved these changes

@Revolyssup Revolyssup Revolyssup approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request plugin size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreemaan-abhishek @nic-6443 @kayx23 @Revolyssup