feat(jwt-auth): support configuring key_claim_name
#11772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Revolyssup
previously approved these changes
Nov 22, 2024
5 tasks
membphis
reviewed
Nov 25, 2024
Revolyssup
previously approved these changes
Nov 25, 2024
nic-6443
previously approved these changes
Nov 25, 2024
membphis
reviewed
Nov 25, 2024
| } | ||
| }, | ||
| key_claim_name = { | ||
| type = "string", |
There was a problem hiding this comment.
Add a limitation about the length, the minimum length should be 1
empty string isn’t acceptable
shreemaan-abhishek
dismissed stale reviews from nic-6443 and Revolyssup
via
10d83e3
membphis
reviewed
Nov 25, 2024
apisix/plugins/jwt-auth.lua
Outdated
| key_claim_name = { | ||
| type = "string", | ||
| default = "key", | ||
| minLength = "1", |
There was a problem hiding this comment.
this wrong, we should use minLength = 1, it should be a number
https://json-schema.org/understanding-json-schema/reference/string
membphis
approved these changes
Nov 26, 2024
nic-6443
approved these changes
Nov 27, 2024
Revolyssup
approved these changes
Nov 27, 2024
|
This PR fixed #11276 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support configuring key_claim_name like kong: https://docs.konghq.com/hub/kong-inc/jwt/configuration/#config-key_claim_name
Checklist