Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unnecessary ci file #10792

Merged

Conversation

monkeyDluffy6017
Copy link
Contributor

Description

The ci file is unnecessary, we don't need to install the lua deps of master branch in current branch
The following ci file is enough which install the lua deps of current branch:
https://github.com/apache/apisix/blob/master/.github/workflows/cli.yml

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@AlinsRan
Copy link
Contributor

Removing this file will cause cli-master to report an error, and we still need to delete the file https://github.com/apache/apisix/blob/master/.github/workflows/cli-master.yml#L23

@monkeyDluffy6017 monkeyDluffy6017 merged commit 59f9dc2 into apache:master Jan 11, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants