fix: install apisix-runtime when install APISIX from source #10729

Vacant2333 · 2023-12-28T08:33:00Z

Description

we have replace openresty by apisix-runtime now, but t he user guide and install-dependencies.sh have not been update

Fixes #10684

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Vacant <vacant@MasterNode.local>

utils/install-dependencies.sh

moonming · 2024-01-02T02:14:16Z

utils/install-dependencies.sh

+        sudo yum -y install centos-release-scl
+        sudo yum -y install devtoolset-9 patch wget
+        set +eu
+        source scl_source enable devtoolset-9
+        set -eu


What do these dependencies do? There was no such thing before

Previously, we used to use compiled apisix runtime repo packages, but now building from source code requires these dependencies.
Centos requires a higher version of gcc..

what's the reason to compile apisix-runtime from the source?

Publishing the apisix-runtime repo will cause the installation of the apisix 3.7.0 deb package to fail.

CI is built using source code and should be consistent.

The apisix deb/rpm is a complete package and does not rely on the apisix runtime repo package, so building the apisix runtime is just an intermediate process.

moonming · 2024-01-02T02:14:46Z

utils/install-dependencies.sh

+    sudo yum install -y  \
+        gcc gcc-c++ curl wget unzip xz gnupg perl-ExtUtils-Embed cpanminus patch \
+        perl perl-devel pcre pcre-devel openldap-devel \
+        openresty-zlib-devel openresty-pcre-devel


What do these dependencies do? There was no such thing before

Previously, apsix-runtime was not built from source code.

moonming · 2024-01-02T02:15:59Z

utils/install-dependencies.sh

 }

 # Install dependencies on ubuntu and debian
 function install_dependencies_with_apt() {
    # add OpenResty source
    sudo apt-get update
-    sudo apt-get -y install software-properties-common wget lsb-release
+    sudo apt-get -y install software-properties-common wget lsb-release gnupg patch


The reason is the same as before, unless we do not build from the apisix runtime source code.

moonming · 2024-01-02T02:16:15Z

utils/install-dependencies.sh

-    # install OpenResty and some compilation tools
-    sudo apt-get install -y git openresty curl openresty-openssl111-dev make gcc libpcre3 libpcre3-dev libldap2-dev unzip
+    # install some compilation tools
+    sudo apt-get install -y curl make gcc g++ cpanminus libpcre3 libpcre3-dev libldap2-dev unzip openresty-zlib-dev openresty-pcre-dev


moonming · 2024-01-02T02:17:03Z

docs/zh/latest/building-apisix.md

 ```

-现在，你可以运行以下命令，从 Github 克隆 APISIX 源码：
+现在，切换到 APISIX 源码的目录，你可以通过以下命令安装依赖项：


No dependencies in the command line

moonming · 2024-01-02T02:17:30Z

ci/redhat-ci.sh

-
-    export luajit_xcflags="-DLUAJIT_ASSERT -DLUAJIT_NUMMODE=2 -DLUAJIT_ENABLE_LUA52COMPAT -O0"
-    export debug_args=--with-debug
+    yum install -y openresty-pcre-devel openresty-zlib-devel


why add this?

It is required to build the apisix-runtime.

Makefile

docs/en/latest/building-apisix.md

monkeyDluffy6017 · 2024-01-02T02:38:26Z

ci/redhat-ci.sh

-    yum -y install https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm
-
-    export luajit_xcflags="-DLUAJIT_ASSERT -DLUAJIT_NUMMODE=2 -DLUAJIT_ENABLE_LUA52COMPAT -O0"
-    export debug_args=--with-debug


./build-apisix-runtime.sh latest contains debug information.

Without with-debug, our test cases cannot pass.

Makefile

monkeyDluffy6017 · 2024-01-02T03:19:05Z

ci/centos7-ci.sh

@@ -43,9 +42,9 @@ install_dependencies() {

    # install openresty to make apisix's rpm test work
    yum install -y yum-utils && yum-config-manager --add-repo https://openresty.org/package/centos/openresty.repo
-    export luajit_xcflags="-DLUAJIT_ASSERT -DLUAJIT_NUMMODE=2 -DLUAJIT_ENABLE_LUA52COMPAT -O0"
-    export debug_args=--with-debug


Why do you remove export debug_args=--with-debug, all debug log will be suppressed

./build-apisix-runtime.sh latest contains debug information.

Without with-debug, our test cases cannot pass.

monkeyDluffy6017 · 2024-01-02T03:22:47Z

utils/install-dependencies.sh

-        # install OpenResty and some compilation tools
-        # shellcheck disable=SC2086
-        sudo yum install -y openresty $common_dep
+    sudo yum-config-manager --add-repo "https://openresty.org/package/${1}/openresty.repo"


No need apisix repo any more?

monkeyDluffy6017 · 2024-01-02T03:25:10Z

utils/install-dependencies.sh

+    if [ -f "./utils/linux-install-luarocks.sh" ]; then
+        ./utils/linux-install-luarocks.sh
+    elif [ -f "./linux-install-luarocks.sh" ]; then
+        ./linux-install-luarocks.sh


The file linux-install-luarocks.sh is under the directory utils, why need this judge?

The script can be executed separately in the utils/ directory.

Co-authored-by: Liu Wei <375636559@qq.com>

docs/en/latest/building-apisix.md

shreemaan-abhishek

LGTM

Vacant2333 and others added 4 commits December 28, 2023 16:29

fix install apisix from source, update the docs

e64e321

Signed-off-by: Vacant <vacant@MasterNode.local>

Merge remote-tracking branch 'upstream/master' into HEAD

a9d6143

build apisix-runtime on deps

b8387ac

add source install ci

4dd5c45

AlinsRan marked this pull request as draft December 29, 2023 06:24

AlinsRan added 2 commits December 29, 2023 16:38

update apisix-runtime 1.1.1

d52b7e7

fix ci

94893ce

AlinsRan marked this pull request as ready for review December 29, 2023 08:57

fix openssl3 prefix

35a4d3b

AlinsRan requested review from bzp2010, monkeyDluffy6017, Revolyssup and shreemaan-abhishek December 29, 2023 09:48

Vacant2333 commented Dec 29, 2023

View reviewed changes

utils/install-dependencies.sh Outdated Show resolved Hide resolved

utils/install-dependencies.sh Outdated Show resolved Hide resolved

remove annotations and add sudo permission

cc2e1a8

moonming reviewed Jan 2, 2024

View reviewed changes

shreemaan-abhishek reviewed Jan 2, 2024

View reviewed changes

Makefile Show resolved Hide resolved

Makefile Show resolved Hide resolved

Makefile Show resolved Hide resolved

docs/en/latest/building-apisix.md Outdated Show resolved Hide resolved

monkeyDluffy6017 reviewed Jan 2, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

monkeyDluffy6017 reviewed Jan 2, 2024

View reviewed changes

monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jan 2, 2024

AlinsRan and others added 2 commits January 3, 2024 11:57

Update Makefile

e57c5a1

Co-authored-by: Liu Wei <375636559@qq.com>

update doc

2073c4f

AlinsRan requested review from monkeyDluffy6017, moonming, shreemaan-abhishek and AlinsRan January 3, 2024 04:28

shreemaan-abhishek reviewed Jan 3, 2024

View reviewed changes

docs/en/latest/building-apisix.md Show resolved Hide resolved

shreemaan-abhishek approved these changes Jan 3, 2024

View reviewed changes

moonming approved these changes Jan 3, 2024

View reviewed changes

monkeyDluffy6017 approved these changes Jan 3, 2024

View reviewed changes

monkeyDluffy6017 merged commit bf9e9f8 into apache:master Jan 3, 2024
71 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: install apisix-runtime when install APISIX from source #10729

fix: install apisix-runtime when install APISIX from source #10729

Vacant2333 commented Dec 28, 2023

moonming Jan 2, 2024

AlinsRan Jan 3, 2024

moonming Jan 3, 2024

AlinsRan Jan 3, 2024 •

edited

Loading

moonming Jan 2, 2024

AlinsRan Jan 3, 2024

moonming Jan 2, 2024

AlinsRan Jan 3, 2024

moonming Jan 2, 2024

moonming Jan 2, 2024

AlinsRan Jan 3, 2024

moonming Jan 2, 2024

AlinsRan Jan 3, 2024

monkeyDluffy6017 Jan 2, 2024 •

edited

Loading

AlinsRan Jan 3, 2024

monkeyDluffy6017 Jan 2, 2024

AlinsRan Jan 3, 2024

monkeyDluffy6017 Jan 2, 2024

AlinsRan Jan 3, 2024

monkeyDluffy6017 Jan 2, 2024

AlinsRan Jan 3, 2024

shreemaan-abhishek left a comment

fix: install apisix-runtime when install APISIX from source #10729

fix: install apisix-runtime when install APISIX from source #10729

Conversation

Vacant2333 commented Dec 28, 2023

Description

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlinsRan Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monkeyDluffy6017 Jan 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shreemaan-abhishek left a comment

Choose a reason for hiding this comment

AlinsRan Jan 3, 2024 •

edited

Loading

monkeyDluffy6017 Jan 2, 2024 •

edited

Loading