Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Plugin Metadata in Terminology #10702

Merged
merged 11 commits into from
Dec 25, 2023
Merged

docs: Add Plugin Metadata in Terminology #10702

merged 11 commits into from
Dec 25, 2023

Conversation

smileby
Copy link
Contributor

@smileby smileby commented Dec 24, 2023 •
edited
Loading

Description

Fixes #9261

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@smileby smileby mentioned this pull request Dec 24, 2023
Closed
pottekkat
pottekkat requested changes Dec 24, 2023
View reviewed changes
Copy link
Member

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good.

@smileby smileby requested a review from pottekkat December 24, 2023 14:18
@pottekkat
Copy link
Member

Please also check the lint error.

@smileby smileby requested a review from pottekkat December 24, 2023 15:00
pottekkat
pottekkat previously approved these changes Dec 24, 2023
View reviewed changes
@pottekkat pottekkat requested a review from kayx23 December 24, 2023 15:02
kayx23
kayx23 requested changes Dec 25, 2023
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition; some minor suggestions below:

@kayx23 kayx23 requested a review from pottekkat December 25, 2023 08:49
@pottekkat pottekkat merged commit feedd06 into apache:master Dec 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayx23 kayx23 kayx23 approved these changes

@pottekkat pottekkat pottekkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Add Plugin Metadata in Terminology
3 participants
@smileby @pottekkat @kayx23