docs: improve description of name for all logger plugins #10701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kayx23, this is my first commit, please check if it meets expectations, I will do next doc. |
|
The content is ok. The Chinese doc needs some format fixes. Please see the failed CI check. Thanks! |
I think that's done~ |
kayx23
reviewed
Dec 24, 2023
| @@ -46,7 +46,7 @@ It might take some time to receive the log data. It will be automatically sent a | |||
| | access_key_id | True | AccessKey ID in Alibaba Cloud. See [Authorization](https://www.alibabacloud.com/help/en/log-service/latest/create-a-ram-user-and-authorize-the-ram-user-to-access-log-service) for more details. | | |||
| | access_key_secret | True | AccessKey Secret in Alibaba Cloud. See [Authorization](https://www.alibabacloud.com/help/en/log-service/latest/create-a-ram-user-and-authorize-the-ram-user-to-access-log-service) for more details. | | |||
| | include_req_body | True | When set to `true`, includes the request body in the log. | | |||
| | name | False | Unique identifier for the batch processor. | | |||
| | name | False | Unique identifier for the batch processor. If you use Prometheus to monitor APISIX metrics, the name is exported in `apisix_batch_process_entries`. | | |||
There was a problem hiding this comment.
it sometimes says "for the batch processor", some other times it's "for the logger" or "to identify the logger"; they should be consistent since they're all for the same purpose.
It is uniquer identifier for the batcher processor of the logger.
monkeyDluffy6017
added
the
wait for update
Vacant2333
approved these changes
Dec 25, 2023
kayx23
requested changes
Dec 25, 2023
Ok I synced names |
kayx23
approved these changes
Dec 25, 2023
kayx23
removed
wait for update
monkeyDluffy6017
approved these changes
Dec 25, 2023
pottekkat
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10689
changes:
Checklist