-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grpc-web plugin supports trailers as part of response body #10613
Conversation
@shreemaan-abhishek #10573 Linked Issue |
@Affanmir great job, can you add test cases as well? |
Sure I'll have to have a look on what framework you are using |
you can get some help here: https://apisix.apache.org/docs/apisix/internal/testing-framework/ and here: https://apisix.apache.org/docs/apisix/building-apisix/ |
This needs some more work, I want to introduce a few more "Access-Control-Allow-Headers" to support different web apps. I'll also want to fix another small issue related to prefix matching paths for routes. |
@Affanmir is this pr ready? |
@Affanmir hello~ whats the status of the pr now, will it be process~ |
ready for review and merge |
@Affanmir the CI is failing. |
@shreemaan-abhishek can the workflows be rerun? apologies for the delay on my end |
@Affanmir , can you please list down the tasks that are complete with this PR ?
So what do you say ? |
The PR is complete. What this PR does
Further bugs/features missing in this plugin that you can work on
|
@shreemaan-abhishek , please run the workflow. |
@Affanmir apart from the test-case you created, there should be a test for the grpc-status trailer, as it was encountered in your issue |
@Affanmir, please run |
@Affanmir , are you referring to this :
Ref : https://web.dev/articles/introduction-to-fetch#response_types |
|
Description
Fixes # (issue)
Checklist