Make the path type configurable in ingress rules. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1: This is blocking for us, we can't use APISIX behind the ALB as it's only routing to strictly |
|
(I would also make it configurable on the admin ingress ?) |
|
@Gallardot @AlinsRan Hello, would you be able to take a quick look at this one ? It should be quite fast to review and merge :) Thanks |
jompu
force-pushed
the
configure-ingress-pathtype
branch
from
71b283d
to
a09e9a1
Compare
The 2.x development has changed from dev to master since I created this, so I have updated the branch to match latest master. And this pull request to merge into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some problems at least with ALB ingress controller and APISIX gateway, when the path type is ImplementationSpecific. Setting path type to Prefix fixed the issue.