feat: timezone and extra env vars configurable in apisix ingress controller #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papdaniel
force-pushed
the
tz-and-extra-env-vars
branch
from
802e2bf
to
1f88e2b
Compare
zll600
reviewed
Jan 30, 2024
| @@ -185,6 +186,7 @@ The same for container level, you need to set: | |||
| | serviceMonitor.annotations | object | `{}` | @param serviceMonitor.annotations ServiceMonitor annotations | | |||
| | serviceMonitor.labels | object | `{}` | @param serviceMonitor.labels ServiceMonitor extra labels | | |||
| | serviceMonitor.metricRelabelings | object | `{}` | @param serviceMonitor.metricRelabelings MetricRelabelConfigs to apply to samples before ingestion. ref: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#metric_relabel_configs | | |||
| | timezone | string | `""` | timezone is the timezone where apisix uses. For example: "UTC" or "Asia/Shanghai" This value will be set on apisix-ingress-controller container's environment variable TZ. You may need to set the timezone to be consistent with your local time zone, otherwise the apisix-ingress-controller's logs may be used to retrieve event in wrong timezone. | | |||
There was a problem hiding this comment.
Suggested change
| | timezone | string | `""` | timezone is the timezone where apisix uses. For example: "UTC" or "Asia/Shanghai" This value will be set on apisix-ingress-controller container's environment variable TZ. You may need to set the timezone to be consistent with your local time zone, otherwise the apisix-ingress-controller's logs may be used to retrieve event in wrong timezone. | | |
| | timezone | string | `""` | timezone is the timezone where apisix-ingress-controller uses. For example: "UTC" or "Asia/Shanghai" This value will be set on apisix-ingress-controller container's environment variable TZ. You may need to set the timezone to be consistent with your local time zone, otherwise the apisix-ingress-controller's logs may be used to retrieve event in wrong timezone. | |
| @@ -183,6 +183,25 @@ affinity: {} | |||
| # ref: https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/#spread-constraints-for-pods | |||
| topologySpreadConstraints: [] | |||
|
|
|||
| # -- timezone is the timezone where apisix uses. | |||
There was a problem hiding this comment.
Suggested change
| # -- timezone is the timezone where apisix uses. | |
| # -- timezone is the timezone where apisix-ingress-controller uses. |
|
@Revolyssup @AlinsRan Could you help review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apisix helm chart has TZ and extra env vars config, these would be useful in apisix-ingress-controller too.
Currently it runs in UTC+8, we would like to set it to another timezone.
issue: #681