[hotfix] Update time and storage units in template configuration files #3434
+18
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3434 +/- ##
============================================
- Coverage 21.59% 21.58% -0.01%
Complexity 2353 2353
============================================
Files 431 431
Lines 40347 40353 +6
Branches 5711 5712 +1
============================================
Hits 8712 8712
- Misses 30903 30909 +6
Partials 732 732
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Based on the optimizations in #3418 and #3423, the ams configuration file now supports parsing time and storage units, and we need to update the template file to prompt the user for the latest usage.
Close #xxx.
Brief change log
dist/src/main/amoro-bin/conf/config.yamlto the new version example.charts/amoro/templates/common/amoro-configmap.yamlto the new version example.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation