add startTime to paginator.paginate when fetching logs in GlueJobHook #46950
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawwar
commented
Feb 22, 2025
Comment on lines
+250
to
+251
| (datetime.now() - timedelta(hours=24)).timestamp() * 1000 | ||
| ), # 24 hours ago in milliseconds |
There was a problem hiding this comment.
We can definitely have an instance variable within hook that we can use to across as a startTime. Not really sure if we should hard code this. But, open to ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to the issue for a detailed discussion
fixes #44694