GO-4346: After exporting Templates, they become unlinked #1993
+202
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
AnastasiaShemyakinskaya
changed the title
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
KirillSto
reviewed
Jan 10, 2025
core/block/export/export.go
Outdated
Comment on lines
496
to
502
| objectsTypes = lo.Union(objectsTypes, []string{objectTypeId}) | ||
| setOfList := details.GetStringList(bundle.RelationKeySetOf) | ||
| setOf = lo.Union(setOf, setOfList) | ||
| targetObjectType := details.GetString(bundle.RelationKeyTargetObjectType) | ||
| if targetObjectType != "" { | ||
| objectsTypes = lo.Union(objectsTypes, []string{targetObjectType}) | ||
| } |
There was a problem hiding this comment.
It seems this code could be made more elegant, if we present for-cycle by relation keys SetOf, Type and TargetObjectType. In the iteration-body we can try to GetString first and then GetStringList. Or maybe GetStringList is a fallback for these two methods. Need to consult @deff7 🙂
There was a problem hiding this comment.
I agree, but setOf is added to another slice, so I think it makes sense to create such for-cycle for targetObjectType and objectType values
There was a problem hiding this comment.
Maybe it is better to introduce inner field(s) to exportContext struct, so there would be no necessity to return values?
Signed-off-by: AnastasiaShemyakinskaya <shem98a@mail.ru>
KirillSto
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract object id from
TargetObjectTyperelation in case it is present in object and add to result export archive, so in case of pb import we also import template object type.