Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Us Updated #927

Closed
wants to merge 1 commit into from
Closed

Rate Us Updated #927

wants to merge 1 commit into from

Conversation

zalabhavy
Copy link
Contributor

Related Issue

Fixes: #889

Description

Here I added favicon in Rating Us Page and made Rating Us Page Responsive with use of html , Css and Javascript.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

image
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 8:55am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@zalabhavy
Copy link
Contributor Author

Hey Anurag, I've made our rate us pages responsive, added subtle effects for a better user experience, and included a favicon for a more professional look. So please Merge my pull request thank you.

@huamanraj
Copy link
Collaborator

Related Issue

Fixes: #889

Description

Here I added favicon in Rating Us Page and made Rating Us Page Responsive with use of html , Css and Javascript.

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

image
image

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

this is not a good way of make responsive!
with the text with icon must be

@huamanraj huamanraj closed this May 27, 2024
@zalabhavy zalabhavy deleted the RateUs branch May 29, 2024 10:18
@zalabhavy zalabhavy restored the RateUs branch May 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:Rating Us Page is not Responsive and No favicon in Rating Us page
2 participants