Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue "there is no logout button on index page. it is in login page so move that from login page to index page after login ! " #791

Merged
merged 3 commits into from
May 24, 2024

Conversation

roushanverma23
Copy link
Contributor

@roushanverma23 roushanverma23 commented May 23, 2024

Description

Added logout button after login page and firrebase authentication using google solved

Fixes: #774 #785

Type of change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • [x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x] This change requires a documentation update

Checklist:

  • [ x] I have made this from my own
  • [ x] I have taken help from some online resources
  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings

image

image

@huamanraj , @anuragverma108 please review

here is deploy link for testing: https://swagrv.netlify.app/

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 9:27pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@huamanraj huamanraj added gssoc This Contribution is under GirlScript Summer of Code 2024 level3 Advance labels May 24, 2024
@huamanraj huamanraj merged commit 70eb192 into anuragverma108:main May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GirlScript Summer of Code 2024 level3 Advance
Projects
None yet
2 participants