[PUT Project] Added CI with format testing and building #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ftr, this PR also includes commits from #1 |
glatosinski
reviewed
Jan 21, 2024
pkoscik
force-pushed
the
ci
branch
2 times, most recently
from
79997a8 to
c89b732
Compare
|
rebased onto #1 (+ changed the target branch) ptal @glatosinski |
pkoscik
reviewed
Jan 21, 2024
glatosinski
requested changes
Jan 22, 2024
jbylicki
force-pushed
the
add-format-support
branch
10 times, most recently
from
cba76d7 to
2706198
Compare
|
@glatosinski applied the suggestions, dropped the DNM |
|
actually the pipeline fails... i was sure that it was green, sorry for spam |
|
GH Actions: grabthecam-build: Fixed code linting - maybe let's squash it with the first commit that actually introduces this change? |
squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the full CI implementation for testing image format conversion (taking into account that some formats can be lossy) and building for grabthecam.