Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license for HTTP grammar #4237

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Add license for HTTP grammar #4237

merged 2 commits into from
Sep 29, 2024

Conversation

Marti2203
Copy link
Contributor

I had made a simple HTTP grammar a couple of years ago and at that time the rules for license inclusion were not well defined.
I was recently contacted to remediate this.

@kaby76
Copy link
Contributor

kaby76 commented Sep 15, 2024

Looks like a regression for the tester. I will need to fix this before we can redo the tests.

@kaby76
Copy link
Contributor

kaby76 commented Sep 16, 2024

This grammar just does not work. #4244

The grammar didn't have a proper EOF-terminated start rule. This caused the parser to "accept" the two inputs (test.http and testHeader.http). But, the parse trees were empty. By design, Antlr rewinds the parser to an acceptable state before an error. In addition, no errors are reported. Note, the tester trgen doesn't test the input, but maybe the old "mvn test" tester did?

@Marti2203
Copy link
Contributor Author

Hi, I will fix it then. Unfortunately, I really do not remember from 5 years ago, so I will spend some time fixing it and make the grammar a better shape.

@kaby76
Copy link
Contributor

kaby76 commented Sep 16, 2024

Much appreciated. It's going to take some time to fix trgen and add regression tests so the build doesn't break too often.

@kaby76
Copy link
Contributor

kaby76 commented Sep 28, 2024

@Marti2203 Could you synch with the latest in master? The updates for build regressions should fix the build for this PR. Thanks!

@teverett
Copy link
Member

@Marti2203 thanks

@teverett teverett merged commit 567a9e4 into antlr:master Sep 29, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants