[build] Fix for #3597 -- Timeouts of coverage, remove for now #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
rvrooman-codelogic
pushed a commit
to CodeLogicIncEngineering/grammars-v4-public-fork
that referenced
this pull request
Jul 27, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #3597.
"Coverage" is a computation that outputs a .html file that is an annotated text file of a grammar. It shows how the grammar is tested, and helps identify what rules in a grammar are not being tested.
Unfortunately, coverage computation takes over 300s, which is monitored and killed, then reported as an error. This PR removes the Github Action for now.
Also, coverage should report whether a change to a grammar is being tested, not necessarily show how the entire grammar is tested.
The plan is to update the tool trcover so that it is faster and add in code to test only the changes.