[MySQL] Avoid confusing label and IPv6 address #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some label combined with some keywords (when written without a space
in between, which is valid for MySQL) can look like beginning of an IPv6
address, e.g.
aaa:BEGIN
is currectly prased as IPv6 address `aaa:be` and leads to a parsing
failure.
Make parsing of IPv6 address more robust and require at least two `:`
to make sure there is no confusion with labels.
KvanTTT
requested changes
Jul 12, 2023
KvanTTT
added
mysql-PositiveTechnologies
Co-authored-by: Ivan Kochurkin <kvanttt@gmail.com>
KvanTTT
approved these changes
Jul 12, 2023
rvrooman-codelogic
pushed a commit
to CodeLogicIncEngineering/grammars-v4-public-fork
that referenced
this pull request
Jul 27, 2023
Some label combined with some keywords (when written without a space
in between, which is valid for MySQL) can look like beginning of an IPv6
address, e.g.
aaa:BEGIN
is currectly parsed as IPv6 address `aaa:be` and leads to a parsing
failure.
Make parsing of IPv6 address more robust and require at least two `:`
to make sure there is no confusion with labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some label combined with some keywords (when written without a space in between, which is valid for MySQL) can look like beginning of an IPv6 address, e.g.
is currectly prased as IPv6 address
aaa:beand leads to a parsing failure.Make parsing of IPv6 address more robust and require at least two
:to make sure there is no confusion with labels.