Fix PostgreSQL set operation precedence #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
handle-set-op-prec
branch
from
145f346
to
2f402f7
Compare
…select_with_parens Signed-off-by: tison <wander4096@gmail.com>
|
test locally with |
|
@teverett is Windows build unstable? I check the CI log and it seems all about package installing instead of tests failure. |
KvanTTT
requested changes
Jul 11, 2023
@KvanTTT The current maven tests seems only test if the query parsed, not the result it parsed out. Shall I build the whole test kit from scratch to verify the op precedence result, or there are some existing tools/cases to leverage? |
Co-authored-by: Ivan Kochurkin <kvanttt@gmail.com>
KvanTTT
approved these changes
Jul 19, 2023
rvrooman-codelogic
pushed a commit
to CodeLogicIncEngineering/grammars-v4-public-fork
that referenced
this pull request
Jul 27, 2023
Now the origin select_cause is redundant since simple_select matches select_with_parens
jiefei30
reviewed
Sep 7, 2023
| : simple_select_pramary (INTERSECT all_or_distinct simple_select_pramary)* | ||
| ; | ||
|
|
||
| simple_select_pramary |
There was a problem hiding this comment.
simple_select_"pramary" ? Do you mean "primary" ?
There was a problem hiding this comment.
This should be a typo 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes from #2378 (comment).
PG treats set ops in different precedence - INTERSECT is tighter than UNION and EXCEPT.