[PLSQL] Single statement without ending semicolon

[mfvitale]

In case of single statement without ending semicolon, do you think this should pass?

I think yes, since this query is valid. The statement should fail if is followed by another one.

[mfvitale]

@KvanTTT To let single statement working without semicolon required lot of changes. Can I gently ask for a review?

[mfvitale]

@KvanTTT Can you please help with

2023-06-30T09:02:35.6906590Z  Build 00:01:16
2023-06-30T09:05:54.3248377Z Parsing grammar /home/runner/work/grammars-v4/grammars-v4/sql/plsql/Generated-CSharp/PlSqlParser.g4
2023-06-30T09:10:52.9763475Z Process is taking longer than 300 seconds. Killing process.
2023-06-30T09:10:53.0751479Z Test failed.
2023-06-30T09:10:53.0776720Z  Test 00:08:18

I need some guidance on how to figure out the issue here. Thanks.

[KvanTTT]

I need some guidance on how to figure out the issue here. Thanks.

It looks like just a problem with CSharp test runner.

[mfvitale]

@KvanTTT thanks for your suggestions. I have applied it.

[KvanTTT]

@kaby76 it looks like there is a problem with coverage CI task. Could you investigate please?

[mfvitale]

@kaby76 it looks like there is a problem with coverage CI task. Could you investigate please?

Seems same issue with CSharp. Any suggestioni?

[kaby76]

I mentioned this for another PR. #3612 (comment)

And I opened an Issue for it. #3597

I will turn off voverage computations for now as this will require a change to trcover, and will take time to make sure it works.

[Thracky]

I should probably open an issue for this but SQLPlus commands do not require a terminating semicolon at all. See section 4.6.1 of the SQLPlus user guide here: https://docs.oracle.com/en/database/oracle/oracle-database/23/sqpug/SQL-Plus-basics.html#GUID-4F029548-6DD2-468F-B6E1-E6D6AA59014B

So if you have a file that starts with:

WHENEVER SQLERROR EXIT

SET ECHO ON

CREATE OR REPLACE PACKAGE ...

These changes make the parser bail out immediately on the SET and it is perfectly legal syntax for SQLPlus commands.