Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLSL, (System)Verilog] Tiny improvements, new examples #3353

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[GLSL, (System)Verilog] Tiny improvements, new examples #3353

wants to merge 7 commits into from

Conversation

msagca
Copy link
Contributor

@msagca msagca commented Apr 27, 2023

@msagca msagca marked this pull request as draft April 27, 2023 11:42
@msagca msagca changed the title [GLSL, (System)Verilog] update desc.xml for testing preprocessor grammars [GLSL, (System)Verilog] update desc.xml to enable testing of preprocessor grammars Feb 26, 2024
@msagca msagca mentioned this pull request Sep 18, 2024
Open
@msagca msagca changed the title [GLSL, (System)Verilog] update desc.xml to enable testing of preprocessor grammars [GLSL, (System)Verilog] Bug fixes, small improvements, new examples Sep 18, 2024
@msagca msagca marked this pull request as ready for review September 18, 2024 21:43
@msagca msagca changed the title [GLSL, (System)Verilog] Bug fixes, small improvements, new examples [GLSL, (System)Verilog] Tiny improvements, new examples Sep 19, 2024
@msagca
Copy link
Contributor Author

msagca commented Sep 19, 2024 •
edited
Loading

Hi @teverett,

For my previous commit, all except 1 test passed but the remaining one timed out after 6 hours for no obvious reason. Now, again 23 out of 24 passed quickly but one is still in progress and looks like it's stuck. The OS is Mac in both cases. It was CSharp target then and now it's Java.

Do you have any opinions on why this is happening?
Thanks.

@kaby76
Copy link
Contributor

kaby76 commented Sep 19, 2024

The MacOS github machines are infamous. Always doing timeouts. Should be fine to mrge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msagca @kaby76