Patch to fix a number of TypeScript issues #4403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericvergnaud please review! |
|
fyi: I had to switch from ts-node to tsx, because I could not get ts-node to work in the ANTLR4 test (even though I use it successfully in other projects). For test execution it makes no difference, however. |
This was referenced Sep 3, 2023
|
Hey Mike, sorry was away from my computer for a couple of days. |
|
Yes, that happens, no worries. I had to close this PR because of serious conflicts after the 4.13.1 release. Will open a new one in a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large patch to fix a large number of TypeScript issue, making this runtime now usable by more than just simple parse tasks.