Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "override" before EOF in TS #4373

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Conversation

GP4cK
Copy link
Contributor

@GP4cK GP4cK commented Aug 3, 2023

Currently, when targeting TS, ANTLR will generate a parser file with this code:
image

This PR adds the override keyword to fix this issue.

Signed-off-by: GP4cK <gautier.bayzelon@gmail.com>
@mike-lischke
Copy link
Member

Obsolete with my patch #4403. Can be closed.

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt added this to the 4.13.2 milestone Sep 9, 2023
@parrt parrt merged commit 98d6fab into antlr:dev Sep 9, 2023
42 checks passed
@GP4cK GP4cK deleted the typescript-override-eof branch September 10, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants