Improved error messages #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to remove the PR description by default when submitting PRs 😅 I added this to provide a checklist (mostly to myself) of what's to be done before this can be merged. The code looks good. Do you mind fixing the formatting and adding some tests for the new error messages? I can add the changelog entry myself. Thanks for this!! |
… are triggered in specific places and may be updated in other places in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have improved the error messages emitted from the parser/lexer by providing more context and hints to fix the error. My implementation includes a new file, containing code which allow us to better debug tokens, by type.