Inline functions redo #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit
…builtins on the qbe backend
YerinAlexey
requested changes
Mar 21, 2024
src/command/run.rs
Outdated
Comment on lines
54
to
87
| Target::Qbe => { | ||
| let dir_path = "./"; // TODO: Use this for changind build directory | ||
| let filename = in_file.file_stem().unwrap().to_str().unwrap(); | ||
| let ssa_path = format!("{dir_path}{}.ssa", filename); | ||
| let asm_path = format!("{dir_path}{}.s", filename); | ||
| let exe_path = format!("{dir_path}{}.exe", filename); | ||
|
|
||
| let mut ssa_file = OpenOptions::new() | ||
| .read(true) | ||
| .write(true) | ||
| .create(true) | ||
| .open(&ssa_path).unwrap(); | ||
| let buff = *buf; | ||
| ssa_file.write_all(&buff).unwrap(); | ||
|
|
||
|
|
||
| // SSA to ASM | ||
| Command::new("qbe") | ||
| .arg(&ssa_path) | ||
| .arg("-o") | ||
| .arg(&asm_path) | ||
| .spawn().unwrap(); | ||
|
|
||
| // ASM to EXE | ||
| Command::new("gcc") | ||
| .arg(&asm_path) | ||
| .arg("-o") | ||
| .arg(&exe_path) | ||
| .spawn().unwrap(); | ||
|
|
||
| // Run the EXE | ||
| Command::new(exe_path) | ||
| .spawn().unwrap(); | ||
| } |
There was a problem hiding this comment.
This should be in a different PR as it's not a requirement for the shorthand returns
There was a problem hiding this comment.
I personally don't mind the addition here. Saves time and trouble. ✌️
|
I get an fn main() {
println(greet("World"))
}
fn greet(name: string) = "Hello " + nameCould you add some tests to the I created a parser test that I used to debug the error: #[test]
fn test_parse_inline_function() {
let raw = "
fn main() = 1
";
let tokens = tokenize(raw).unwrap();
let tree = parse(tokens, Some(raw.to_string()), "".into());
assert!(tree.is_ok())
}I didn't have enough time to investigate this further though. Trying again later. |
garritfra
force-pushed
the
inline_functions
branch
from
bd5503e to
c28422d
Compare
|
Okay, it seems like the error is an issue with how the |
|
I think this is ready to merge. Thanks @hexaredecimal for your work, I love this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have followed your advice and implemented inline functions from the parser. I also added a function/method for creating hints. I had some time on my hands so I also decide to start working on the run command for qbe. I'm thinking of refactoring the code to a function to reduce the code size of the match expression.