Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit warnings Creation of dynamic property $candownload and assertObjectHasAttribute() is deprecated #70

Open
leonstr opened this issue Nov 4, 2024 · 1 comment
Open

PHPUnit warnings Creation of dynamic property $candownload and assertObjectHasAttribute() is deprecated #70

leonstr opened this issue Nov 4, 2024 · 1 comment

Comments

@leonstr
Copy link

leonstr commented Nov 4, 2024

Running PHPUnit tests with Moodle 4.5 (Build: 20241101) and PHP 8.3 shows multiple instances of the following warnings:

Deprecated: Creation of dynamic property filter_ally\renderables\wrapper::$candownload is deprecated in /root/405/filter/ally/tests/filter_test.php on line 870

and:

filter_ally\jwthelper_test::test_jwttoken_valid
assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() instead.
@leonstr
Copy link
Author

leonstr commented Nov 4, 2024

Proposed fix in #71.

@leonstr leonstr mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leonstr