Skip to content

Commit

Permalink
Fix inconsistencies in reload module implementation and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
ohartl authored and ansibleguy committed Jan 1, 2024
1 parent 30512ce commit e9325cc
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/source/modules/2_reload.rst
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Definition
:header: "Parameter", "Type", "Required", "Default", "Aliases", "Comment"
:widths: 15 10 10 10 10 45

"target","string","true","\-","tgt, t","What part of the running config should be reloaded. One of: 'alias', 'route', 'cron', 'unbound', 'syslog', 'ipsec', 'shaper', 'monit', 'wireguard', 'interface_vlan', 'interface_vxlan', 'frr', 'webproxy'"
"target","string","true","\-","tgt, t","What part of the running config should be reloaded. One of: 'alias', 'rule', 'route', 'cron', 'unbound', 'syslog', 'ipsec', 'ipsec_legacy', 'shaper', 'monit', 'wireguard', 'interface_vlan', 'interface_vxlan', 'interface_vip', 'frr', 'webproxy', 'bind', 'ids'"

.. include:: ../_include/param_basic.rst

Expand Down
21 changes: 18 additions & 3 deletions plugins/modules/reload.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,24 @@ def run_module():
target=dict(
type='str', required=True, aliases=['tgt', 't'],
choices=[
'alias', 'route', 'cron', 'unbound', 'syslog', 'ipsec', 'shaper',
'monit', 'wireguard', 'interface_vlan', 'interface_vxlan', 'frr',
'webproxy', 'interface_vip', 'bind', 'ipsec_legacy', 'ids',
'alias',
'rule',
'route',
'cron',
'unbound',
'syslog',
'ipsec',
'ipsec_legacy',
'shaper',
'monit',
'wireguard',
'interface_vlan',
'interface_vxlan',
'interface_vip',
'frr',
'webproxy',
'bind',
'ids',
],
description='What part of the running config should be reloaded'
),
Expand Down
3 changes: 3 additions & 0 deletions tests/reload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@
when: not ansible_check_mode
loop:
- 'alias'
- 'rule'
- 'route'
- 'cron'
- 'unbound'
- 'syslog'
- 'ipsec'
- 'ipsec_legacy'
Expand All @@ -31,3 +33,4 @@
- 'frr'
- 'webproxy'
- 'bind'
- 'ids'

0 comments on commit e9325cc

Please sign in to comment.