-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added hot reload to receptor config #1135
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #1135 +/- ##
========================================
Coverage ? 43.43%
========================================
Files ? 36
Lines ? 7192
Branches ? 0
========================================
Hits ? 3124
Misses ? 3829
Partials ? 239
|
03e92e0
to
68fd0de
Compare
68fd0de
to
bf5d63a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good,
I would like a few more comments around the reflection function to make it quicker to read once we revisit later
The functionality looks good to me,
@thom-at-redhat and @matoval can you look also please
85a353d
to
b73a6bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I have a few questions
46b0c5b
to
3e9576c
Compare
Quality Gate passedIssues Measures |
No description provided.