From ab0066a15fc0f3b5073b2ce886941771442095bf Mon Sep 17 00:00:00 2001 From: Thom Carlin Date: Wed, 17 Jan 2024 14:41:44 -0500 Subject: [PATCH] Reverted default to false --- pkg/workceptor/kubernetes.go | 4 ++-- pkg/workceptor/kubernetes_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/workceptor/kubernetes.go b/pkg/workceptor/kubernetes.go index f5f1bc339..1e412fb94 100644 --- a/pkg/workceptor/kubernetes.go +++ b/pkg/workceptor/kubernetes.go @@ -748,7 +748,7 @@ func (kw *kubeUnit) runWorkUsingLogger() { func shouldUseReconnect() bool { // Support for streaming from pod with timestamps using reconnect method is in all current versions // Can override the detection by setting the RECEPTOR_KUBE_SUPPORT_RECONNECT - // accepted values: "enabled", "disabled", "auto" with "enabled" being the default + // accepted values: "enabled", "disabled", "auto" with "disabled" being the default // all invalid value will assume to be "disabled" env, ok := os.LookupEnv("RECEPTOR_KUBE_SUPPORT_RECONNECT") @@ -765,7 +765,7 @@ func shouldUseReconnect() bool { } } - return true + return false } func parseTime(s string) *time.Time { diff --git a/pkg/workceptor/kubernetes_test.go b/pkg/workceptor/kubernetes_test.go index 23500ede9..4c2d9184e 100644 --- a/pkg/workceptor/kubernetes_test.go +++ b/pkg/workceptor/kubernetes_test.go @@ -18,7 +18,7 @@ func TestShouldUseReconnect(t *testing.T) { { name: "Positive (undefined) test", envValue: "", - want: true, + want: false, }, { name: "Enabled test", @@ -33,7 +33,7 @@ func TestShouldUseReconnect(t *testing.T) { { name: "Auto test", envValue: "auto", - want: true, + want: false, }, { name: "Default test",