Do not lock around writing to stdout, do not flush

[sivel]

Do not lock around writing to stdout, do not flush

[sivel]

This stuff is unnecessary for this PR, and if desired I can remove the last commit. Looking at things like this just drove me a little crazy:

log_only = args[5] if len(args) >= 6 else kwargs.get('log_only', False)

[nitzmahone]

You can't safely functools.cache the bound args this way- any non-hashable value passed to a display method would cause a runtime error. There isn't really a benefit to caching this one in real-world usage anyway, since every unique combination of args is a new cache entry, so this would basically just be a memory leak bound by the size of the cache. Several of the display methods happily accept unhashable args, and last I checked there are a number of callers that blindly pass arbitrary objects to display methods.

Caching the signature this way should be fine (though you might want to verify that inspect isn't already doing so), since method objects are usually immutable/hashable.

[sivel]

Signature objects are hashable, and as far as I have been able to confirm they are not cached within inspect.

I was also skeptical of caching the _getcallargs function, purely for the concern of how much it would cache. I'll remove that one.

[sivel]

Reproducer for deadlock:

runme.py

import os
import ansible_runner

r = ansible_runner.run(
    private_data_dir=os.path.abspath(os.getcwd()),
    playbook='playbook.yml',
    inventory='hosts',
    forks=50,
    settings=dict(
        suppress_ansible_output=True,
    ),
)

project/action_plugins/chatty.py

from __future__ import annotations

from ansible.plugins.action import ActionBase
from ansible.utils.display import Display

display = Display()


class ActionModule(ActionBase):
    def run(self, tmp=None, task_vars=None):
        host = task_vars['inventory_hostname']
        for i in range(100):
            for a in ('display', 'v', 'vv', 'vvv', 'vvvv', 'vvvvv', 'vvvvvv', 'verbose', 'warning', 'debug'):
                getattr(display, a)(f'<{host}> chatty {i=} {a=}')
        return {}

Create an inventory with 100 hosts, and a playbook just like:

- hosts: all
  gather_facts: false
  tasks:
    - chatty: