Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-9] Make apache2_mod_proxy work with Python 3, half-way modern Apache 2 versions, and add basic tests #9772

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Backport of #9762 to stable-9.

There was a small conflict in the documentation.

ISSUE TYPE
  • Bugfix Pull Request
  • Refactoring Pull Request
  • Test Pull Request
COMPONENT NAME

apache2_mod_proxy

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module plugins plugin (any type) tests tests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 18, 2025
…ersions, and add basic tests (ansible-collections#9762)

* Move Apache 2 installation to setup role.

* Make module work with Python 3.

* Add basic tests.

* Add changelog fragment.

* Simplify change.

* Pass referer.
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 18, 2025
@felixfontein
Copy link
Collaborator Author

Getting this to run locally was not trivial; I had to use ansible-core's stable-2.13 branch (the latest 2.13 release didn't work) and manually patch its ansible-test to work with newer Python versions (simply removing the version check worked fine).

… place with find_all/findAll (ansible-collections#9775)

Follow-up for ansible-collections#9762, forgot one place.

(cherry picked from commit 8e36fd4)
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 18, 2025
@felixfontein felixfontein merged commit 1a0a44d into ansible-collections:stable-9 Feb 18, 2025
153 checks passed
@felixfontein felixfontein deleted the mod_proxy branch February 18, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants