hpilo_boot: fix module failing when trying to power on an already powered-on server

[ryanb74]

SUMMARY

For this module to be idempotent, it should be successful when trying to reach a power state which is already there.

It was already the case for "poweroff", however when running the module with "boot_once" state, it was failing if the server was already powered_on, which is not an idempotent behavior

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

hpilo_boot.py

ADDITIONAL INFORMATION

Before change, when running the module with state = "boot_once", the module fails :

Tuesday 28 January 2025  11:08:58 +0100 (0:00:00.012)       0:00:00.344 *******
fatal: [localhost]: FAILED! => {
    "changed": false,
    "msg": "HP iLO (server) reports that the server is already powered on !"
}

PLAY RECAP *******************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0  

After change, when running the module with state = "boot_once", the module is successful and doesn't change anything :

Tuesday 28 January 2025  11:11:51 +0100 (0:00:00.012)       0:00:00.326 *******
ok: [localhost] => {
    "changed": false,
    "power": "ON"
}

PLAY RECAP *******************************************************************************************************************************************************************************************
localhost                  : ok=3    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

[ansibullbot]

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/hpilo_boot.py:191:12: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/hpilo_boot.py:191:12: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/hpilo_boot.py:191:12: E111: indentation is not a multiple of 4

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/modules/hpilo_boot.py:191:12: E111: indentation is not a multiple of 4

click here for bot help

[ansibullbot]

cc @haad
click here for bot help

[russoz]

Hi @ryanb74 Thanks for your contribution!

Please beware this is a breaking change - people might have code out there that expects it to fail. We need to take the long route on this one - add the new behaviour with a feature flag, deprecate the "old" behaviour, and later on remove the "old" behaviour entirely (along with the feature flag).

[felixfontein]

@ryanb74 ping

needs_info