Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apache2-mod-proxy: make state option a list #9600

Merged
merged 4 commits into from
Jan 23, 2025
Merged

apache2-mod-proxy: make state option a list #9600

merged 4 commits into from
Jan 23, 2025
+11 −12

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 22, 2025 •
edited
Loading

SUMMARY

Parameter state is a str, but it is parsed for comma separated values with a fixed set of values allowed. Transforming that into a list of str elements makes the code simpler.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

apache2_mod_proxy

@ansibullbot
Copy link
Collaborator

cc @oboukili
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) labels Jan 22, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Jan 22, 2025
@russoz @felixfontein
Update changelogs/fragments/9600-apache2-mod-proxy-revamp2.yml
7cff009 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit a4562bc into ansible-collections:main Jan 23, 2025
138 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 23, 2025 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/a4562bced4ef384a06056db601895acd88bc1216/pr-9600

Backported as #9611

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 23, 2025
@russoz @patchback
apache2-mod-proxy: make state option a list (#9600)
8bbf156 
* apache2-mod-proxy: make state option a list

* add changelog frag

* Update plugins/modules/apache2_mod_proxy.py

* Update changelogs/fragments/9600-apache2-mod-proxy-revamp2.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit a4562bc)
@felixfontein
Copy link
Collaborator

@russoz thanks again!

@patchback patchback bot mentioned this pull request Jan 23, 2025
Open
@russoz russoz deleted the apache2-mod-proxy-revamp-2 branch January 23, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein