Proxmox module refactoring

changelogs/fragments/9225-proxmox-module-refactoring.yml

@@ -0,0 +1,11 @@
+minor_changes:
+  - proxmox - refactors the proxmox module (https://github.com/ansible-collections/community.general/pull/9225).
+
+bugfixes:
+  - proxmox - fixes idempotency of template conversions (https://github.com/ansible-collections/community.general/pull/9225, https://github.com/ansible-collections/community.general/issues/8811).
+  - proxmox - fixes issues with disk_volume variable (https://github.com/ansible-collections/community.general/pull/9225, https://github.com/ansible-collections/community.general/issues/9065).
+  - proxmox - fixes incorrect parsing for bind-only mounts (https://github.com/ansible-collections/community.general/pull/9225, https://github.com/ansible-collections/community.general/issues/8982).
+  - proxmox module utils - fixes ignoring of ``choose_first_if_multiple`` argument in ``get_vmid`` (https://github.com/ansible-collections/community.general/pull/9225).
+
+deprecated_features:
+  - proxmox - removes default value ``false`` of ``update`` parameter. This will be changed to a default of ``true`` in community.general 11.0.0 (https://github.com/ansible-collections/community.general/pull/9225).

plugins/module_utils/proxmox.py

@@ -144,7 +144,7 @@ def get_vmid(self, name, ignore_missing=False, choose_first_if_multiple=False):
                 return None
 
             self.module.fail_json(msg='No VM with name %s found' % name)
-        elif len(vms) > 1:
+        elif len(vms) > 1 and not choose_first_if_multiple:
             self.module.fail_json(msg='Multiple VMs with name %s found, provide vmid instead' % name)
 
         return vms[0]