Proxmox module refactoring #9225

Lithimlin · 2024-12-06T13:45:59Z

SUMMARY

This pull request refactors the historically grown proxmox module.
The control flow was very opaque with some redundant checks and - most recently - features that were only introduced in parts of the module when they intended to target the whole module (see #9065).
This refactor aims to make the module more readable and more easily extendable.

Additionally, this request contains various bug fixes:

From proxmox: Handling of disk_volume variable is broken #9065: The disk_volume key is now properly parsed and passed on to the API
From not possible to add lxc mount point as bind #8982: It is now possible to add bind-only mount points again.
From proxmox: state=template is not idempotent (for LXCs) #8811: Converting an LXC to a template is now idempotent.
From Update of LXC Containers does not work (Mounts/Memory/etc.) #9055: The default value of update=False is now deprecated and will be changed to update=True in version 11.0.0
In the proxmox utils module: The parameter choose_first_if_multiple of get_vmid is now used correctly, causing the function to return the first of multiple matches instead of failing.

ISSUE TYPE

Bugfix Pull Request
Refactoring Pull Request

COMPONENT NAME

proxmox

ADDITIONAL INFORMATION

The following playbook should run correctly on both the old and refactored versions of this module, but the template creation will not be idempotent on the old version:

---
- name: Check proxmox LXC module
  hosts: pve
  become: false
  gather_facts: false
  tasks:
    - name: Create LXC
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        ostemplate: local:vztmpl/debian-12-standard_12.2-1_amd64.tar.zst
        disk: local-lvm:8
        tags: test1,test3,debian
      register: create_res

    - name: Sleep for 5 seconds and continue with play
      ansible.builtin.wait_for:
        timeout: 5
      delegate_to: localhost

    - name: Check Creation Idempotency
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        ostemplate: local:vztmpl/debian-12-standard_12.2-1_amd64.tar.zst
        disk: local-lvm:8
        tags: test1,test3,debian
      register: check_res
      failed_when: check_res.changed

    - name: Update LXC config [new - create volumes]
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        cores: 1
        vmid: "{{ create_res.vmid | int }}"
        disk_volume:
          storage: local-lvm
          size: 14
        mount_volumes:
          - id: mp0
            storage: local-lvm
            size: 3
            mountpoint: /mnt/test
        update: true

    - name: Update LXC config [new - explicit volumes]
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        cores: 1
        vmid: "{{ create_res.vmid }}"
        disk_volume:
          storage: local-lvm
          volume: "vm-{{ create_res.vmid }}-disk-0"
          size: 14
        mount_volumes:
          - id: mp0
            storage: local-lvm
            volume: "vm-{{ create_res.vmid }}-disk-1"
            size: 3
            mountpoint: /mnt/test
        update: true

    - name: Update LXC config [old - implicit volumes]
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        cores: 1
        vmid: "{{ create_res.vmid }}"
        disk: local-lvm:14
        mounts: '{"mp0":"local-lvm:3,mp=/mnt/test"}'
        update: true

    - name: Update LXC config [old - explicit volumes]
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        cores: 1
        vmid: "{{ create_res.vmid }}"
        disk: "local-lvm:vm-{{ create_res.vmid }}-disk-0,size=14G"
        mounts: '{"mp0":"local-lvm:vm-{{ create_res.vmid }}-disk-1,size=3G,mp=/mnt/test"}'
        update: true

    - name: Update LXC config [tags]
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node
        cores: 1
        vmid: "{{ create_res.vmid }}"
        disk: "local-lvm:vm-{{ create_res.vmid }}-disk-0,size=14G"
        mounts: '{"mp0":"local-lvm:vm-{{ create_res.vmid }}-disk-1,size=3G,mp=/mnt/test"}'
        tags: test1,test2,debian
        update: true

    - name: Start LXC
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: started

    - name: Check Starting Idempotency
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: started
      retries: 1
      delay: 10
      register: check_res
      failed_when: check_res.changed

    - name: Restart LXC
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: restarted

    - name: Stop LXC
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: stopped

    - name: Check Stopping Idempotency
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: stopped
      retries: 1
      delay: 10
      register: check_res
      failed_when: check_res.changed

    - name: Convert LXC to Template
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: template

    - name: Check Template Idempotency
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: template
      retries: 1
      delay: 10
      register: check_res
      failed_when: check_res.changed

    - name: Remove LXC
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: absent

    - name: Check Removal Idempotency
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        vmid: "{{ create_res.vmid }}"
        state: absent
      retries: 1
      delay: 10
      register: check_res
      failed_when: check_res.changed

    - name: Create new LXC [With storage + disk] (should fail)
      community.general.proxmox:
        api_host: "{{ proxmox_api_host }}"
        api_user: "{{ proxmox_api_user }}"
        api_token_id: "{{ proxmox_api_token_id }}"
        api_token_secret: "{{ proxmox_api_token_secret }}"
        node: node01
        hostname: test-node-2
        ostemplate: local:vztmpl/debian-12-standard_12.2-1_amd64.tar.zst
        cores: 1
        disk: 6
        storage: local-lvm
      ignore_errors: true

ansibullbot · 2024-12-06T13:48:14Z

@Lithimlin this PR contains the following merge commits:

1b2476b

Please rebase your branch to remove these commits.

click here for bot help

ansibullbot · 2024-12-06T14:10:07Z

cc @Ajpantuso @Thulium-Drake @UnderGreen @joshainglis @karmab @krauthosting
click here for bot help

russoz

Hi @Lithimlin thanks for your contribution!

I would recommend breaking this PR into smaller pieces, as it seems to contain both bugfixes as well as new features. Additionally, we must not use type hints, as Ansible still provides support for Python 2.7 - it's quite a nuisance, but that should be the case until that support is dropped, I want to say end of next year but I am not sure right now.

changelogs/fragments/9225-proxmox-module-refactoring.yml

plugins/modules/proxmox.py

bcoca · 2024-12-09T15:41:10Z

Ansible still provides support for Python 2.7 - it's quite a nuisance, but that should be the case until that support is dropped, I want to say end of next year but I am not sure right now.

The last 2 versions of core already dropped support for 2.7 and 2.16 will be EOL in May 2025
https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix

russoz · 2024-12-10T08:55:48Z

Ansible still provides support for Python 2.7 - it's quite a nuisance, but that should be the case until that support is dropped, I want to say end of next year but I am not sure right now.

The last 2 versions of core already dropped support for 2.7 and 2.16 will be EOL in May 2025 docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix

Yes, but community.general still supports ansible-core 2.15. Felix mentioned the deadline more than once but it will be late next year - far enough into the future to be forgotten. Until then, in the collection, we must support Python 2.7.

russoz

Hi, I had approved it before, but will mark it "Request changes" to prevent other maintainers from accidentally merging it as-is now. Also, on second thought, this is quite a big revamp, so it would benefit from a more thorough examination before we merge it. I approved it before (and I should not, because the changelog needed fixing) and, days later, I cannot recall what I have seen here or not. I'm writing this to manage the expectations - this PR might take a tad longer to be merged - but please bear with us.

changelogs/fragments/9225-proxmox-module-refactoring.yml

felixfontein · 2025-01-08T21:09:58Z

It looks like there's anohter conflict now (I guess due to #9524). Sorry for the hassle :( I hope this was the last reformat...

This is a squash of the following commits for easier rebasing: proxmox module_utils: make use of choose_first_if_multiple in get_vm proxmox: refactor module proxmox: add changelog proxmox: fix deprecation message proxmox: remove type hints proxmox: remove spaces for keywords proxmox: run formatter proxmox: make compabtible with old python versions proxmox: remove f-strings proxmox: fix string formatting in build_volume proxmox: revert disk size parameter to simple integer proxmox: update changelog fragment proxmox: fix argument spec proxmox: fix size handling in build_volume proxmox: fix formatting proxmox: update changelog fragment

changelogs/fragments/9225-proxmox-module-refactoring.yml

plugins/modules/proxmox.py

russoz

Hi @Lithimlin

I have spent more time looking into it and made it through state=present. Got some comments on it. Cheers

plugins/modules/proxmox.py

russoz · 2025-01-12T01:54:10Z

plugins/modules/proxmox.py

+        if not vmid and not hostname:
+            self.module.fail_json(msg="Either VMID or hostname must be provided.")


Is this not something that should be guaranteed by the module required_* arguments? It seems that all the module states call get_lxc_resource(), so I reckon it would make more sense to add a required_one_of with ("vmid", "hostname") and remove this check from here, no?

I can add the required_one_of, but this is more a check in place for the function itself so it is not misused.

The functions within this file are not meant to be imported elsewhere, so in theory if not in practice, the only misuse that can happen is in this file as well. If you could guarantee that is not the case, then this check could be removed.

It already has a required_one_of vmid hostname, so possibly that part is already done.

I suppose that means I should properly document all functions in this module as well

Ah, actually, I remember why I did it this way: This is preparation for being able to safely use this function in the module_utils.

russoz · 2025-01-12T02:07:34Z

plugins/modules/proxmox.py

+    def get_lxc_resource_by_id(self, vmid):
+        vms = self.get_vm_resources()

-            if (proxmox.stop_instance(vm, vmid, timeout, force=module.params['force']) and
-                    proxmox.start_instance(vm, vmid, timeout)):
-                module.exit_json(changed=True, vmid=vmid, msg="VM %s is restarted" % vmid)
+        vms = [vm for vm in vms if vm["vmid"] == vmid]
+        if len(vms) == 0:
+            raise LookupError("VM with VMID %d does not exist in cluster." % vmid)
+
+        return vms[0]
+


This method plus the get_vm_resources() one below seem to do almost the exact same thing as ProxmoxAnsible.get_vm(), defined in plugin/module_utils/proxmox.py:152-164.

The module_utils' code seems to have more checks and safety around types (the vmid parameter is an int in the module options, the PR code does not seem to deal with that, comparing int to str, for example), but the PR code does use a more specific exception (LookupError), which is usually a good thing.

Is there any compelling reason to have two new methods that do almost the same thing as existing code? If yes, please expand, else, please remove the new ones and make any improvements you feel necessary on the existing ones so that other modules may benefit from them.

Somewhere down the line I'd love to put get_vm_resources() and get_lxc_resource_by_id() into the utils module, but I didn't want to replace it there as that would require me to check all other modules for functionality as well. I have neither the setup nor the time to do that unfortunately.

What I could do is add both of these new functions to the utils module so they can be used down the line and possibly deprecate the old one, but I'm not sure how good of an idea that is.

russoz · 2025-01-12T02:26:29Z

plugins/modules/proxmox.py

+    def get_vm_resources(self):
+        try:
+            return self.proxmox_api.cluster.resources.get(type="vm")
        except Exception as e:
-            module.fail_json(vmid=vmid, msg="restarting of VM %s failed with exception: %s" % (vmid, e))
+            self.module.fail_json(
+                msg="Unable to retrieve list of %s VMs from cluster resources: %s"
+                % (self.VZ_TYPE, e)
+            )



This indeed would be better placed in the module_utils, and methods get_vmid() and get_vm() (the ones on my screen at the moment, may others as well but not searching right now) could be refactored and benefit from it.

plugins/modules/proxmox.py

russoz · 2025-01-12T03:34:05Z

plugins/modules/proxmox.py

-            vm = proxmox.get_vm(vmid)
-            if getattr(proxmox.proxmox_api.nodes(vm['node']), VZ_TYPE)(vmid).status.current.get()['status'] == 'running':
-                module.exit_json(changed=False, vmid=vmid, msg="VM %s is already running" % vmid)
+            lxc = self.get_lxc_resource(vmid, hostname)


Given that the module claims to work with both lxc and openvz VMs, it might be more neutral to call this variable vm instead of lxc.

Suggested change

lxc = self.get_lxc_resource(vmid, hostname)

vm = self.get_lxc_resource(vmid, hostname)

Actually, the method also could have a more neutral name.

While that is true, this ties into the discussion of dropping openvz support since it's from a Proxmox version that is way past its EOL.

plugins/modules/proxmox.py

russoz · 2025-01-22T09:05:50Z

plugins/modules/proxmox.py

+        self.module.fail_json(
+            vmid=vmid,
+            msg="VM %s does not exist but neither clone nor ostemplate were specified!"
+            % identifier,
+        )


Is this case ever going to happen? Line 742 (required_if state present) guarantee at least one of update (in which case this method new_lxc_instance() does not get called), clone or ostemplate is passed. Please double check, if sure it won't happen, please remove.

It is possible for the LXC to not exist, but update being set to true, in which case neither clone nor ostemplate need to be set according to the module definition.

felixfontein · 2025-01-25T09:42:10Z

@russoz @Lithimlin what's the current state of the PR? Is everyone happy so we can merge this for 10.3.0? I guess we won't get more feedback from users of the module here, unless it ends up in a release...

russoz

Well, I'm approving on the basis that it seems to have been carefully tailored, but I have not really examined all the logic paths. Again, this PR is way too big - it would have been better to create a number of smaller ones.
@Lithimlin I understand/assume you have tested this thoroughly and I am approving based on that.

patchback · 2025-01-26T15:06:17Z

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/d71ba0fae80c4b47074c2472c96a086fa39f595a/pr-9225

Backported as #9634

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* proxmox: Refactor This is a squash of the following commits for easier rebasing: proxmox module_utils: make use of choose_first_if_multiple in get_vm proxmox: refactor module proxmox: add changelog proxmox: fix deprecation message proxmox: remove type hints proxmox: remove spaces for keywords proxmox: run formatter proxmox: make compabtible with old python versions proxmox: remove f-strings proxmox: fix string formatting in build_volume proxmox: revert disk size parameter to simple integer proxmox: update changelog fragment proxmox: fix argument spec proxmox: fix size handling in build_volume proxmox: fix formatting proxmox: update changelog fragment * proxmox: Fix changelog fragment, doc, and deprecation string formatting. * proxmox: Fix formatting in imports * proxmox: require one of `vmid` or `hostname`, simplify checks * proxmox: apply check for supported features to entire module * proxmox: move parameter conversions inside create and update functions (cherry picked from commit d71ba0f)

felixfontein · 2025-01-26T15:06:34Z

@Lithimlin thanks a lot for your contribution!
@russoz @bcoca thanks a lot for reviewing this!

…9634) Proxmox module refactoring (#9225) * proxmox: Refactor This is a squash of the following commits for easier rebasing: proxmox module_utils: make use of choose_first_if_multiple in get_vm proxmox: refactor module proxmox: add changelog proxmox: fix deprecation message proxmox: remove type hints proxmox: remove spaces for keywords proxmox: run formatter proxmox: make compabtible with old python versions proxmox: remove f-strings proxmox: fix string formatting in build_volume proxmox: revert disk size parameter to simple integer proxmox: update changelog fragment proxmox: fix argument spec proxmox: fix size handling in build_volume proxmox: fix formatting proxmox: update changelog fragment * proxmox: Fix changelog fragment, doc, and deprecation string formatting. * proxmox: Fix formatting in imports * proxmox: require one of `vmid` or `hostname`, simplify checks * proxmox: apply check for supported features to entire module * proxmox: move parameter conversions inside create and update functions (cherry picked from commit d71ba0f) Co-authored-by: JL Euler <Lithimlin@users.noreply.github.com>

ansibullbot added bug This issue/PR relates to a bug merge_commit This PR contains at least one merge commit. Please resolve! module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Dec 6, 2024

Lithimlin force-pushed the proxmox-module-fixing branch from 6fcef97 to c2ffd98 Compare December 6, 2024 13:52

This comment was marked as resolved.

Sign in to view

russoz approved these changes Dec 7, 2024

View reviewed changes

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Dec 8, 2024

This comment was marked as resolved.

Sign in to view

ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Dec 10, 2024

This comment was marked as resolved.

Sign in to view

russoz requested changes Dec 11, 2024

View reviewed changes

changelogs/fragments/9225-proxmox-module-refactoring.yml Outdated Show resolved Hide resolved

changelogs/fragments/9225-proxmox-module-refactoring.yml Outdated Show resolved Hide resolved

ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 6, 2025

ansibullbot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 8, 2025

Lithimlin force-pushed the proxmox-module-fixing branch from edab74c to 0c87d71 Compare January 9, 2025 10:00

ansibullbot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jan 9, 2025

felixfontein reviewed Jan 10, 2025

View reviewed changes

russoz reviewed Jan 12, 2025

View reviewed changes

ansibullbot added stale_ci CI is older than 7 days, rerun before merging stale_review labels Jan 20, 2025

Lithimlin added 5 commits January 21, 2025 11:22

proxmox: Fix changelog fragment, doc, and deprecation string formatting.

c9599b4

proxmox: Fix formatting in imports

7c6daa0

proxmox: require one of vmid or hostname, simplify checks

2d0da2d

proxmox: apply check for supported features to entire module

8836a53

proxmox: move parameter conversions inside create and update functions

d00d61f

ansibullbot removed stale_ci CI is older than 7 days, rerun before merging stale_review labels Jan 21, 2025

russoz reviewed Jan 22, 2025

View reviewed changes

russoz approved these changes Jan 26, 2025

View reviewed changes

ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jan 26, 2025

felixfontein merged commit d71ba0f into ansible-collections:main Jan 26, 2025
138 checks passed

patchback bot mentioned this pull request Jan 26, 2025

[PR #9225/d71ba0fa backport][stable-10] Proxmox module refactoring #9634

Merged

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 26, 2025

Lithimlin deleted the proxmox-module-fixing branch January 27, 2025 08:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proxmox module refactoring #9225

Proxmox module refactoring #9225

Lithimlin commented Dec 6, 2024

ansibullbot commented Dec 6, 2024

This comment was marked as resolved.

ansibullbot commented Dec 6, 2024

russoz left a comment

bcoca commented Dec 9, 2024

russoz commented Dec 10, 2024

This comment was marked as resolved.

This comment was marked as resolved.

russoz left a comment

felixfontein commented Jan 8, 2025

russoz left a comment

russoz Jan 12, 2025

Lithimlin Jan 21, 2025

russoz Jan 22, 2025 •

edited

Loading

Lithimlin Jan 22, 2025

Lithimlin Jan 22, 2025

russoz Jan 12, 2025

Lithimlin Jan 21, 2025

russoz Jan 12, 2025

russoz Jan 12, 2025

Lithimlin Jan 21, 2025

russoz Jan 22, 2025

Lithimlin Jan 22, 2025

felixfontein commented Jan 25, 2025

russoz left a comment

patchback bot commented Jan 26, 2025 •

edited

Loading

felixfontein commented Jan 26, 2025

		if not vmid and not hostname:
		self.module.fail_json(msg="Either VMID or hostname must be provided.")

	lxc = self.get_lxc_resource(vmid, hostname)
	vm = self.get_lxc_resource(vmid, hostname)

Proxmox module refactoring #9225

Proxmox module refactoring #9225

Conversation

Lithimlin commented Dec 6, 2024

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Dec 6, 2024

This comment was marked as resolved.

ansibullbot commented Dec 6, 2024

russoz left a comment

Choose a reason for hiding this comment

bcoca commented Dec 9, 2024

russoz commented Dec 10, 2024

This comment was marked as resolved.

This comment was marked as resolved.

russoz left a comment

Choose a reason for hiding this comment

felixfontein commented Jan 8, 2025

russoz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

russoz Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

felixfontein commented Jan 25, 2025

russoz left a comment

Choose a reason for hiding this comment

patchback bot commented Jan 26, 2025 • edited Loading

Backport to stable-10: 💚 backport PR created

felixfontein commented Jan 26, 2025

russoz Jan 22, 2025 •

edited

Loading

patchback bot commented Jan 26, 2025 •

edited

Loading