Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash from lack of CL credentials #8

Open
anseljh opened this issue Dec 21, 2016 · 7 comments
Open

Fix crash from lack of CL credentials #8

anseljh opened this issue Dec 21, 2016 · 7 comments
Assignees

Comments

@anseljh
Copy link
Owner

anseljh commented Dec 21, 2016

Reported by user, need to reproduce

@anseljh anseljh self-assigned this Dec 21, 2016
@jordanlcouch
Copy link

jordanlcouch commented Dec 21, 2016

So it took a few steps, but I essentially was able to delete everything related to courtlistener from the settings.ini file and the casebot.py file and after I did that I was able to run the program. My edited versions of the files are attached.

Casebot minus CL.zip

@mlissner
Copy link
Contributor

I'm confused. Are you trying to run casebot without any credentials for CourtListener? It seems like a crash is perfectly reasonable in that case? If it's working without credentials, that's because "anonymous" users can make a few queries before they hit their usage threshold. That's not a good way to use the API though in deployed code because it will soon fail...

@mlissner
Copy link
Contributor

(I'm the maintainer of CourtListener, BTW.)

@anseljh
Copy link
Owner Author

anseljh commented Dec 21, 2016

@mlissner IIRC, Casebot has run fine without CL credentials, but yes, it would be limited eventually. In practice, this may not happen because Casebot use is likely very low volume.

@jordanlcouch
Copy link

@mlissner noted, I had had trouble getting CL to authenticate properly so this was a fix

@mlissner
Copy link
Contributor

mlissner commented Dec 21, 2016

In practice, this may not happen because Casebot use is likely very low volume.

Probably true. It goes by IP address if you're not logged in, so it probably would be fine without auth. I still encourage it because it makes my life easier, but you could probably get by without.

Can I help make it work? It should be very easy. It's usually just a header with the token in it.

@anseljh
Copy link
Owner Author

anseljh commented Dec 21, 2016

@mlissner Casebot does authenticate to CL if you give it the token in the .ini file. I just made it optional. Will take a look at @jordanlcouch's files later to see what's up. Thanks to both of you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants