-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pos] Add epoch argument to vp::pos::rewards (backport #4196) #4302
Conversation
Cherry-pick of 7937b91 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint-libs-0.47 #4302 +/- ##
===================================================
+ Coverage 74.07% 74.17% +0.10%
===================================================
Files 345 345
Lines 110155 110565 +410
===================================================
+ Hits 81592 82009 +417
+ Misses 28563 28556 -7 ☔ View full report in Codecov by Sentry. |
(cherry picked from commit 7937b91) # Conflicts: # .changelog/libs-v0.47.0/SDK/4196-rewards-at-past-epoch.md
(cherry picked from commit cb29c9d)
(cherry picked from commit 3c47541)
(cherry picked from commit 8cb563f)
(cherry picked from commit c988a40)
…larify that it only returns accumulated rewards available to claim (cherry picked from commit ec6763b)
…e state before invoking the shortcut (cherry picked from commit aacd109)
…imed (cherry picked from commit 03db9de)
27df524
to
62fe537
Compare
Describe your changes
This adds an
epoch
argument to therewards()
function invp::pos
. It does require a RPC node update in order to work, but it's backwards compatible. Tested with previous build ofnamadan
and results are same as before:With node on
main
and client on this branch:With both client and node on this branch:
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repoThis is an automatic backport of pull request #4196 done by [Mergify](https://mergify.com).