Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update masp and ibc txs handling #275

Open
wants to merge 15 commits into
base: 1.0.0-maint
Choose a base branch
from
Open

Conversation

grarco
Copy link

@grarco grarco commented Feb 14, 2025

Based on #267.

  • Fixes masp note extraction to point to a single inner tx instead of being duplicated for every tx of a batch
  • Fixes handling of shielded masp txs
  • Fixes extraction of ibc transfer data
  • Adds the conversions to the tally of masp notes
  • Caches ibc tokens when extracting the transfer data instead of recomputing them

Minor:

  • Makes the masp internal address a constant
  • Misc refactors and renaming
  • Reduces code duplication

NOTE: ibc nfts transfers are not indexed at the moment

@grarco grarco marked this pull request as ready for review February 14, 2025 14:35
@grarco grarco requested review from Fraccaman and sug0 February 14, 2025 14:35
@Fraccaman
Copy link
Member

mind pointing this to 1.0.0-maint?

@grarco grarco changed the base branch from main to 1.0.0-maint February 14, 2025 14:55
@grarco grarco force-pushed the grarco/fix-masp-txs branch from 80552d1 to 087d26e Compare February 14, 2025 14:59
@grarco grarco mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants