Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings' search should be cancellable #18051

Open
Arthur-Milchior opened this issue Mar 4, 2025 · 4 comments · May be fixed by #18057
Open

Settings' search should be cancellable #18051

Arthur-Milchior opened this issue Mar 4, 2025 · 4 comments · May be fixed by #18057
Assignees

Comments

@Arthur-Milchior
Copy link
Member

Arthur-Milchior commented Mar 4, 2025

How to reproduce:

  • Open settings
  • Search any term
  • Press back

Expected result:

  • The settings menu

Actual result:

  • Closing the settings

If I was looking for a setting and don't find it so I need to browse, having the settings closed on me is frustrating

AnkiDroid Version = 2.21alpha13 (8614558)
Backend Version = 0.1.50-anki25.02 (25.02 038d85b1d9e1896e93a3e4a26f600c79ddc33611)
Android Version = 15 (SDK 35)
ProductFlavor = play
Device Info = Google | google | husky | husky | Pixel 8 Pro | husky
Webview User Agent = Mozilla/5.0 (Linux; Android 15; Pixel 8 Pro Build/AP4A.250205.002; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/133.0.6943.137 Mobile Safari/537.36
ACRA UUID = 1ee1be7e-8149-4589-aca8-f45e0b56a2a5
FSRS = 2.0.3 (Enabled: false)
Crash Reports Enabled = true

@iamits-07
Copy link

Hi! I'd like to work on this issue as my first contribution. Could you please assign it to me?

@rishabh-jain89
Copy link

Hey @Arthur-Milchior! I'd like to work on this issue. Do I need to be assigned to it, or can I start working on it immediately and submit a PR?

@Amit-kumar80844
Copy link

"I've identified an issue where, after searching in settings and then clearing the search text, Anki does not revert to the previous settings screen as expected. I believe this happens because the test case does not properly handle the scenario where the search text becomes null. I would like to work on fixing this behavior to ensure that clearing the search restores the previous settings screen correctly."
assign to me please

@Akshit517
Copy link

"I've identified an issue where, after searching in settings and then clearing the search text, Anki does not revert to the previous settings screen as expected. I believe this happens because the test case does not properly handle the scenario where the search text becomes null. I would like to work on fixing this behavior to ensure that clearing the search restores the previous settings screen correctly." assign to me please

The issue is related to back stack management when you press back button not when clearing the 'search text' result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants