Dark mode toggle

[aaditx23]

Added dark mode toggle in settings

[aniruddha-adhikary]

@aaditx23 Can you please add screenshots and video recording of it working please?

[aaditx23]

Yes. Here is the preview

2024-12-02.21-36-24.mp4

[aaditx23]

[Mahmud0808]

It seems there's an issue with the status bar color.

[aaditx23]

@Mahmud0808 the issue you are talking about, is this it?

[Mahmud0808]

@Mahmud0808 the issue you are talking about, is this it?

Yes, statusbar content doesn't follow the theme selected. Instead it follows the system theme.

[aaditx23]

@Mahmud0808 the issue you are talking about, is this it?

Yes, statusbar content doesn't follow the theme selected. Instead it follows the system theme.

Fixing it...

[aaditx23]

@Mahmud0808 the issue you are talking about, is this it?

Yes, statusbar content doesn't follow the theme selected. Instead it follows the system theme.

Fixing it...

Made the statusbar transparent for now, so the font is visible. but will work on it a bit later, don't have anything to test the ios version yet.

EDIT: Issue fixed in android, looking for a mac to work on the ios variant

[aaditx23]

The issue is fixed for both android and ios.
Here is a screen record:

2024-12-09.20-26-17.mp4

[aniruddha-adhikary]

Will review this tonight!

[aniruddha-adhikary]

Tested, works perfectly @aaditx23! Thank you so much for all the effort. I absolutely love the spirit of us working together to build a better app.

I was thinking from the user perspective, the app behavior has changed a bit. Before the app would automatically go to Dark Mode depending on the system. Should we completely remove that functionality?

[aaditx23]

@aniruddha-adhikary thank you so much.

As we have a toggle now, i guess we can remove it. What do you think?

I can try to implement that as well. should be doable. let me know.

[aaditx23]

Not following system theme by default might fall under bad UX so i have fixed it.

Here is a sped up screen record.

fix_follows_system_theme_changed.mp4