Refactor: Handle ambient mode in Exercise screens #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces changes to handle ambient mode within individual exercise screens instead of globally. - An AmbientAware composable is added to each screen to control ambient behavior. - Modifiers for ambient mode (ambientGray, ambientBlank) are applied within the screen composables. - Removed the ambientState parameter from composables and adjusted accordingly.
Migrated from `HorizontalPager` and `ScreenScaffold` to `PagerScreen` for better navigation within the exercise screen. Adjusted the control button logic to navigate between screens using coroutines and `animateScrollToPage` when resuming or pausing an exercise. Updated the layout to accommodate the new structure and improve the user experience.
Migrated from `HorizontalPager` and `ScreenScaffold` to `PagerScreen` for better navigation within the exercise screen. Adjusted the control button logic to navigate between screens using coroutines and `animateScrollToPage` when resuming or pausing an exercise. Updated the layout to accommodate the new structure and improve the user experience.
This change adds Ambient support for the Exercise and Preparing screens: - The Exercise screen now supports the Ambient state by displaying a blank screen when ambient. - The Preparing screen now uses a gray background when ambient. - Updates existing screenshot tests to cover ambient state.
Migrated `AmbientAware` and `AmbientState` from the local package to the Horologist library. This change updates the imports to use the Horologist versions of these components.
kul3r4
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces changes to handle ambient mode within individual exercise screens instead of globally.
Uses a temporary copy of AmbientAware until horologist release