Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildfix - missing implementation of other methods in LocationListener. #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karczews
Copy link

@karczews karczews commented Mar 16, 2021

As per the commit message - both compileSdkVersion and targetSdkVersion aims at API 29, not 30. In 29, onProviderDisabled(String provider), onProviderEnabled(String provider) and onStatusChanged(String provider, int status, Bundle extras) are non-default and needs to be implemented explicitly.

ref. #8

@google-cla
Copy link

google-cla bot commented Mar 16, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@karczews karczews changed the title Buildfix - missing implementation of other methods in LocationListener. [9] Buildfix - missing implementation of other methods in LocationListener. Mar 16, 2021
@google-cla
Copy link

google-cla bot commented Mar 16, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Mar 16, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…iderDisabled(String provider), onProviderEnabled(String provider) and onStatusChanged(String provider, int status, Bundle extras) are non-default and needs to be implemented explicitly.
@karczews karczews changed the title [9] Buildfix - missing implementation of other methods in LocationListener. Buildfix - missing implementation of other methods in LocationListener. Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant