Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Always have opt_xt in the poped.db #76

Open
mattfidler opened this issue Sep 21, 2024 · 2 comments
Open

Feature Request: Always have opt_xt in the poped.db #76

mattfidler opened this issue Sep 21, 2024 · 2 comments

Comments

@mattfidler
Copy link
Contributor

Currently it seems to be here:

poped.db$settings$optsw[2]

But it isn't always in the poped.db.

Right now babelmixr2 check to see if the times are optimized to see if time matching is needed. It would be helpful if this could be queried in the poped.db...

@andrewhooker
Copy link
Owner

andrewhooker commented Oct 4, 2024

Hi Matt,

poped.db$settings$optsw[2] should always be in the poped.db. Do you have an example where it is not?

Since the poped.db is editable and can be transformed by the user, including the user changing/updating sampling times, it seems dangerous to have a flag indicating if sample times have been optimized. Further, being optimized by one algorithm may not indicate optimality by another algorithm (D-optimal vs Ds-optimal for example).

Thoughts? I'm not sure this is doable.

@mattfidler
Copy link
Contributor Author

I haven't looked at this for a bit, though I thought I encountered an example where it was not. Perhaps it was that it could be changed dynamically.

As it turns out, I don't think it is that critical. I found another way of matching that doesn't take too much time, so the time difference is minimal.

However, I do have differences in outcomes based on if I match times or not. I guess this isn't a surprise and is why many of your examples match the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants