You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I try to download zip sources from a github url, e.g. https://codeload.github.com/andresusanto/easydl/zip/refs/heads/master but the file is just called "master" (I tried with another repo actually and it was called "main"). If I print the content-disposition header in the .on("metadata",...) method, I see the correct file name, but dl.savedFilePath is just the name of the branch.
The text was updated successfully, but these errors were encountered:
This feature is not implemented. I think the problem is that the final target file name would then only be known once the metadata is received (i.e., the headers), and so the final filename is not available. The issue is that the _ensureDest method is being called too early in the process, before we have the headers.
Should be supported by #27 — if you pass a target dir it will fetch the headers and infer the filename from the content disposition headers, if available. It will fallback to the last path component.
I try to download zip sources from a github url, e.g. https://codeload.github.com/andresusanto/easydl/zip/refs/heads/master but the file is just called "master" (I tried with another repo actually and it was called "main"). If I print the content-disposition header in the
.on("metadata",...)
method, I see the correct file name, butdl.savedFilePath
is just the name of the branch.The text was updated successfully, but these errors were encountered: