Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LEDs using ledc method #49

Open
andreisperid opened this issue May 4, 2023 · 0 comments
Open

Implement LEDs using ledc method #49

andreisperid opened this issue May 4, 2023 · 0 comments
Labels
firmware Arduino code flashed into the device
Milestone
v2.1.0

Comments

@andreisperid
Copy link
Owner

As commented, currently the LEDs (ledChar and ledFinish) are using analogWrite, which are by convenience supplied by the ESP32Servo library. This might be bad for modularity in case another library is used, or any changes in the architecture are made.

And, maybe there are other opportunities by using this official method.
@andreisperid andreisperid added the firmware Arduino code flashed into the device label May 4, 2023
@andreisperid andreisperid added this to the v1.3.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
firmware Arduino code flashed into the device
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
1 participant
@andreisperid