fix decode dpt1 after refactoring byte interpretation in parser refs #56

andreek · Nov 19, 2018 · efa680a · efa680a
1 parent 893738d
commit efa680a
Show file tree

Hide file tree

Showing 5 changed files with 201 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,5 @@
 node_modules/
 .project
 .DS_Store
+.nyc_output/
+.tern-project
diff --git a/lib/decoder.js b/lib/decoder.js
@@ -195,10 +195,7 @@ Decoder.prototype.decode = function(len, data, callback) {
   // eis 1 / dpt 1.xxx
   if(len === 8) {
     type = 'DPT1';
-    value = data-64;
-    if(value > 1) {
-      value = value-64;
-    }
+    value = data;
   }
 
   // eis 6 / dpt 5.xxx

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eibd",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "node eibd client",
   "main": "./index",
   "repository": {

diff --git a/test/decoder.test.js b/test/decoder.test.js
@@ -12,15 +12,15 @@ describe('Decoder', function() {
   });
   describe('DPT1', function() {
     it('should decode DPT1 value 1', function() {
-      var data = 65;
+      var data = 1;
       enc.decode(8, data, function(err, type, value) {
         assert.equal(err, null);
         assert.equal(type, 'DPT1');
         assert.equal(value, 1);
       });
     }),
     it('should decode DPT1 value 0', function() {
-      var data = 64;
+      var data = 0;
       enc.decode(8, data, function(err, type, value) {
         assert.equal(err, null);
         assert.equal(type, 'DPT1');