[v2.0] issues found in beta 1

[anb0s]

I need help with testing of the next test release beta 1 (2.0.0.yx)

@electrotype Thank You for your help! I very much appreciate it!

• Opening the edition window for an existing entry changes its name back to the original one.
  • *Bug: the setDefaultName(true) should not be executed in this case --> fixed in beta 2, see [v2.0] issues found in beta 2 #54 *
• Adding a new entry sometimes changes the name of the other existing entries back to their original one. I'm not sure when this occures, but I'm 100% sure I've seen it.
  • *Bug: the setDefaultName(true) should not be executed in this case --> fixed in beta 2, see [v2.0] issues found in beta 2 #54 *
• It would be nice if the division of the panel on the main window was draggable/movable (between the "Name" part and the "Command" part)
  • Enhancement: you can resize the preference page and it will resize the table proportionally --> but will investigate
• I would maybe rename the "type" option to "icon". The name "type" kind of suggests it may have an effect on the command when, in fact, it only changes the display icon.
  • Yes, you are right and i want to add an icon selection left to the type. The type itself is like a category of the command and i want to show the predefined menus, commands and tools in categories (tree) and may be to create sub-menus from categories and also show pop-menu per category with defined Key-Shortcuts for each category; so the intention was more then just an icon --> i will think abut it again...
• I wouldn't automatically prefix the "menu name" with the "type" when exiting the "Edit existing command". For example, if I name my command "test", the menu name becomes "Run: test". At least I can edit this menu name back to "test" if I want, but still...
  • *Yes, i have same thoughts and have an idea (prototype implementation) described in issue implement generic tool and command (preset) definition #49 -- > fixed in beta 2, see [v2.0] issues found in beta 2 #54 *
• You probably should remove the "?" (Help) buttons if there is no information when you click them.
  • Yes, i wanted to add an interactive help in the dialogs, but will do it later - it's hard for developers to write user documentation ;)

[electrotype]

Hey anb0s,

It looks very well!!

Some bugs and some suggestions:

• Opening the edition window for an existing entry changes its name back to the original one.
• Adding a new entry sometimes changes the name of the other existing entries back to their original one. I'm not sure when this occures, but I'm 100% sure I've seen it.
• It would be nice if the division of the panel on the main window was draggable/movable (between the "Name" part and the "Command" part)
• I would maybe rename the "type" option to "icon". The name "type" kind of suggests it may have an effect on the command when, in fact, it only changes the display icon.
• I wouldn't automatically prefix the "menu name" with the "type" when exiting the "Edit existing command". For example, if I name my command "test", the menu name becomes "Run: test". At least I can edit this menu name back to "test" if I want, but still...
• You probably should remove the "?" (Help) buttons if there is no information when you click them.

Other than that it's very cool! I like the extra stuff you added:

• Double-click to open a window
• The "Copy..." option
• The selectable "Usable variables" (and double-click to copy them!)
• To be able to target a file or a directory only.

Very good job and thank you!!

[anb0s]

@electrotype Thank You for your help! I very much appreciate it!

• Opening the edition window for an existing entry changes its name back to the original one.

  • Bug: the setDefaultName(true) should not be executed in this case --> will be fixed

• Adding a new entry sometimes changes the name of the other existing entries back to their original one. I'm not sure when this occures, but I'm 100% sure I've seen it.

  • Bug: the setDefaultName(true) should not be executed in this case --> will investigate

• It would be nice if the division of the panel on the main window was draggable/movable (between the "Name" part and the "Command" part)

  • Enhancement: you can resize the preference page and it will resize the table proportionally --> but will investigate

• I would maybe rename the "type" option to "icon". The name "type" kind of suggests it may have an effect on the command when, in fact, it only changes the display icon.

  • Yes, you are right and i want to add an icon selection left to the type. The type itself is like a category of the command and i want to show the predefined menus, commands and tools in categories (tree) and may be to create sub-menus from categories and also show pop-menu per category with defined Key-Shortcuts for each category; so the intention was more then just an icon --> i will think abut it again...

• I wouldn't automatically prefix the "menu name" with the "type" when exiting the "Edit existing command". For example, if I name my command "test", the menu name becomes "Run: test". At least I can edit this menu name back to "test" if I want, but still...

  • Yes, i have same thoughts and have an idea (prototype implementation) described in issue implement generic tool and command (preset) definition #49:

    Yes, for menu names you can select from predefined name patterns like:

    "${easyshell:command_type} with ${easyshell:command_name}" that is fixed in v1.5 test build and expanded to your example "Run with Windows Git-Bash"

    "${easyshell:command_type}: ${easyshell:command_name}" that is default in v2.0 beta 1 build and expanded to your example "Run: Windows Git-Bash"

    etc. or you enter your own name like "Gradle Build (Bash)" directly.

  so in the case user selected the option for type the name directly EasyShell will not overwrite it. What do you think?

• You probably should remove the "?" (Help) buttons if there is no information when you click them.

  • Yes, i wanted to add an interactive help in the dialogs, but will do it later - it's hard for developers to write user documentation ;)

Other than that it's very cool! I like the extra stuff you added:

Thanks :)

• The selectable "Usable variables" (and double-click to copy them!)
  • Actually it's only a workaround. I want to have a better solution like content assist (see issue [v2.0] add content assist to tool / presets definition #48) or a button with "Var.." to select a variable with description etc. like it's done in eclipse launch configurations
• To be able to target a file or a directory only.
  • Yes, the option is there but does not work right, i'm searching for better solution how to create dynamic menus in eclipse and have the selected resource(s) in this context in place. Actually selected resource(s) are checked after the menues are created --> i'm working on it

Thanks again and stay tuned 👍

[anb0s]

tag: V2_0_0_BETA_1 (https://github.com/anb0s/EasyShell/releases/tag/V2_0_0_BETA_1)
commit: e224055

[anb0s]

moved not addressed issues / points to v2.0.0 beta 2 test, see #54