Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging/no os device #2276

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Staging/no os device #2276

wants to merge 29 commits into from

Conversation

dbogdan
Copy link
Contributor

@dbogdan dbogdan commented Aug 13, 2024 •
edited
Loading

Pull Request Description

Add no_os_device.h

To be included in all no-OS drivers.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

dbogdan added 29 commits August 12, 2024 00:21
@dbogdan
include: Add no_os_device.h
ce81ae5 
To be included in all no-OS drivers.

struct no_os_device will hold, among other details, the mandatory compatible
string information.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: accel: Make use of no_os_device.h
1ea1233 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: temperature: Make use of no_os_device.h
020a31b 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: rtc: Make use of no_os_device.h
0102c17 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: adc: Make use of no_os_device.h
e598b9f 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: adc-dac: Make use of no_os_device.h
176afea 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: afe: Make use of no_os_device.h
a8096da 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: amplifiers: Make use of no_os_device.h
f3a2fc7 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: cdc: Make use of no_os_device.h
36cbac9 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: display: Make use of no_os_device.h
a3d8610 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: dac: Make use of no_os_device.h
457a1cf 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: digital-io: Make use of no_os_device.h
0f25224 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: ecg: Make use of no_os_device.h
a00101a 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: eeprom: Make use of no_os_device.h
0075f0b 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: filter: Make use of no_os_device.h
c0b2b2a 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: frequency: Make use of no_os_device.h
1dbbf6d 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: gyro: Make use of no_os_device.h
87ad8ad 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: impedance-analyzer: Make use of no_os_device.h
d98804b 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: imu: Make use of no_os_device.h
be717c3 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: io-expander: Make use of no_os_device.h
9414785 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: io-link: Make use of no_os_device.h
fccba61 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: meter: Make use of no_os_device.h
ad94a5a 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: mux: Make use of no_os_device.h
c1d0dff 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: net: Make use of no_os_device.h
9d1d348 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: photo-electronic: Make use of no_os_device.h
38966cf 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: potentiometer: Make use of no_os_device.h
dccf2d2 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: power: Make use of no_os_device.h
f2f33d8 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: resolver: Make use of no_os_device.h
24af132 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan
drivers: rf-transceiver: Make use of no_os_device.h
b7325e9 
Declare a device driver compatibility list for each driver.

Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
@dbogdan dbogdan marked this pull request as ready for review August 13, 2024 12:52
CiprianRegus
CiprianRegus reviewed Aug 13, 2024
View reviewed changes
drivers/adc-dac/ad74413r/ad74413r.c
* @brief Device driver compatibility list.
*/
const struct no_os_device ad74413r_device_table[] = {
{.compatible = "adi,ad74413r"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AD74412R is also supported by this driver.

@buha
Copy link
Contributor

buha commented Aug 19, 2024

next step would be to add no_os_device.h in src.mk files

@buha
Copy link
Contributor

buha commented Aug 19, 2024

and the next next step would be to actually use these compatible strings in device driver initialization, currently they are unused globals

@buha
Copy link
Contributor

buha commented Aug 19, 2024

and a question: should these also be marked with static ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CiprianRegus CiprianRegus CiprianRegus left review comments

@buha buha Awaiting requested review from buha buha is a code owner

@amiclaus amiclaus Awaiting requested review from amiclaus amiclaus is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbogdan @buha @CiprianRegus